DM-44545: Design initial calibration report format #291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sr525
approved these changes
Oct 9, 2024
sr525
reviewed
Oct 9, 2024
| @@ -104,7 +104,7 @@ def __call__(self, data: KeyedData, ax: Axes, **kwargs) -> KeyedData: | |||
| data[self.xKey] if self.xKey is not None else range(len(data[self.valsKey])), # type: ignore | |||
| data[self.valsKey], # type: ignore | |||
| color=self.color if self.color is not None else None, | |||
| marker=self.marker if self.marker is not None else None, | |||
| marker=self.marker if self.marker is not None else ".", | |||
There was a problem hiding this comment.
I agree that a lot of these defaults seem a little weird.
There was a problem hiding this comment.
There was some pushback to this change on slack, but I plan to still merge it with this logic: merging this change will make some line plots that use this element look different; not merging it will make scatter plots that use this element empty.
czwa
force-pushed
the
tickets/DM-44545
branch
from
559c7ce
to
e23fa6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix missing PTC dataset type.